[ https://issues.apache.org/jira/browse/ARTEMIS-4796?focusedWorklogId=922540&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922540 ]
ASF GitHub Bot logged work on ARTEMIS-4796: ------------------------------------------- Author: ASF GitHub Bot Created on: 07/Jun/24 10:44 Start Date: 07/Jun/24 10:44 Worklog Time Spent: 10m Work Description: gemmellr commented on PR #4959: URL: https://github.com/apache/activemq-artemis/pull/4959#issuecomment-2154566142 Same general review comment as last time. There are still several references to toSimpleString (outside compatibility tests). There is now-unused deprecated stuff that isn't tested. Issue Time Tracking ------------------- Worklog Id: (was: 922540) Time Spent: 3h (was: 2h 50m) > Simplify SimpleString API > ------------------------- > > Key: ARTEMIS-4796 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4796 > Project: ActiveMQ Artemis > Issue Type: Improvement > Reporter: Justin Bertram > Assignee: Justin Bertram > Priority: Major > Time Spent: 3h > Remaining Estimate: 0h > > Instead of using the verbosely named {{toSimpleString}} static factory method > (and its overloaded counterparts), {{SimpleString}} should provide {{of}} > implementations. This change would make the code more concise and readable. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact