[
https://issues.apache.org/jira/browse/ARTEMIS-4305?focusedWorklogId=922596&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922596
]
ASF GitHub Bot logged work on ARTEMIS-4305:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jun/24 14:37
Start Date: 07/Jun/24 14:37
Worklog Time Spent: 10m
Work Description: iiliev2 commented on code in PR #4899:
URL: https://github.com/apache/activemq-artemis/pull/4899#discussion_r1631319204
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/RemotingConnectionImpl.java:
##########
@@ -408,10 +416,15 @@ public void endOfBatch(Object connectionID) {
}
private void doBufferReceived(final Packet packet) {
+ if (isHealthy && !isCorrectPing(packet)) {
+ isHealthy = false;
Review Comment:
Commenting this line out will effectively disable the fix. This will cause
the new test `ZeroPersistenceSymmetricalClusterTest` to fail.
Issue Time Tracking
-------------------
Worklog Id: (was: 922596)
Time Spent: 1h (was: 50m)
> Zero persistence does not work in kubernetes
> --------------------------------------------
>
> Key: ARTEMIS-4305
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4305
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Ivan Iliev
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> In a cluster deployed in kubernetes, when a node is destroyed it terminates
> the process and shuts down the network before the process has a chance to
> close connections. Then a new node might be brought up, reusing the old
> node’s ip. If this happens before the connection ttl, from artemis’ point of
> view, it looks like as if the connection came back. Yet it is actually not
> the same, the peer has a new node id, etc. This messes things up with the
> cluster, the old message flow record is invalid.
> One way to fix it could be if the {{Ping}} messages which are typically used
> to detect dead connections could use some sort of connection id to match that
> the other side is really the one which it is supposed to be.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
