[ https://issues.apache.org/jira/browse/ARTEMIS-4809?focusedWorklogId=923032&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-923032 ]
ASF GitHub Bot logged work on ARTEMIS-4809: ------------------------------------------- Author: ASF GitHub Bot Created on: 11/Jun/24 21:19 Start Date: 11/Jun/24 21:19 Worklog Time Spent: 10m Work Description: jbertram commented on code in PR #4966: URL: https://github.com/apache/activemq-artemis/pull/4966#discussion_r1635492310 ########## artemis-server/src/main/java/org/apache/activemq/artemis/core/settings/impl/AddressSettings.java: ########## @@ -1604,6 +1619,10 @@ public void decode(ActiveMQBuffer buffer, boolean tryCompatible) { prefetchPageMessages = BufferHelper.readNullableInteger(buffer); } + if (buffer.readableBytes() > 0) { + intermediateMessageBufferInitialSize = BufferHelper.readNullableInteger(buffer); + } + Review Comment: Notice the comment below. This code should be removed. Issue Time Tracking ------------------- Worklog Id: (was: 923032) Time Spent: 40m (was: 0.5h) > Make intermediateMessageReferences initial capacity configurable > ---------------------------------------------------------------- > > Key: ARTEMIS-4809 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4809 > Project: ActiveMQ Artemis > Issue Type: New Feature > Components: Broker > Reporter: Josh Byster > Priority: Minor > Time Spent: 40m > Remaining Estimate: 0h > > In some setups, there could be a few hundred thousand queues that are created > due to many consumers that are connecting. However, most of these are empty > and stay empty for the entire day since there aren't necessarily messages to > be sent. > The 8K {{intermediateMessageReferences}} instantiates an 64KB buffer > ({{Object[]}}). This means we have large allocation and live heap that > ultimately remains empty for almost the entire day. > It would be quite nice if we could configure this initial size. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact