[ https://issues.apache.org/jira/browse/ARTEMIS-4923?focusedWorklogId=925699&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-925699 ]
ASF GitHub Bot logged work on ARTEMIS-4923: ------------------------------------------- Author: ASF GitHub Bot Created on: 12/Jul/24 19:50 Start Date: 12/Jul/24 19:50 Worklog Time Spent: 10m Work Description: tabish121 commented on code in PR #5087: URL: https://github.com/apache/activemq-artemis/pull/5087#discussion_r1676392558 ########## artemis-server/src/main/java/org/apache/activemq/artemis/core/server/management/impl/ManagementServiceImpl.java: ########## @@ -692,16 +644,16 @@ public SimpleString getManagementNotificationAddress() { return managementNotificationAddress; } - // ActiveMQComponent implementation ----------------------------- - @Override - public void start() throws Exception { + public synchronized void start() throws Exception { + if (started) { Review Comment: You are right, I got glassy eyed reading all the other removes of synchronized and read that backwards. Ignore me. Issue Time Tracking ------------------- Worklog Id: (was: 925699) Time Spent: 40m (was: 0.5h) > Reduce synchronization in ManagementServiceImpl > ----------------------------------------------- > > Key: ARTEMIS-4923 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4923 > Project: ActiveMQ Artemis > Issue Type: Improvement > Reporter: Justin Bertram > Assignee: Justin Bertram > Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > The {{ManagementService}} is used by the broker to register and unregister > components for management as well as send notifications. When the broker is > busy dealing with new sessions and auto-creating queues, addresses, etc. > there is a lot of contention in this service. However, much of the > synchronization can be removed completely or replaced with more efficient > thread-safe underlying data structures. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact