[
https://issues.apache.org/jira/browse/ARTEMIS-4974?focusedWorklogId=928959&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-928959
]
ASF GitHub Bot logged work on ARTEMIS-4974:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Aug/24 16:07
Start Date: 06/Aug/24 16:07
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #5132:
URL: https://github.com/apache/activemq-artemis/pull/5132#discussion_r1705795086
##########
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/Run.java:
##########
@@ -45,7 +43,7 @@
import picocli.CommandLine.Command;
import picocli.CommandLine.Option;
-@Command(name = "run", description = "Run the broker.")
+@Command(name = "run", description = "Run the broker.", hidden = true)
Review Comment:
If you are just removing run from the shell use case for now, shouldn't this
hidden=true be omitted? Otherwise wont this annotation still take effect for
the regular non-shell case?
Issue Time Tracking
-------------------
Worklog Id: (was: 928959)
Time Spent: 1.5h (was: 1h 20m)
> Disable run from the Shell
> --------------------------
>
> Key: ARTEMIS-4974
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4974
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.37.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> With the separation of profiles in the script, we cannot allow run to be
> called from the Shell, as that would use wrong variables and log4j
> configurations.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
