[ 
https://issues.apache.org/jira/browse/ARTEMIS-4909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871576#comment-17871576
 ] 

Robbie Gemmell commented on ARTEMIS-4909:
-----------------------------------------

Note that the change made following discussion was just to make "Reloading 
configuration: security" be updated to "Reloading configuration: security 
settings", since that is how they are referenced in discussion and 
documentation. The exact XML tags were not used because the configuration can 
be from a variety of sources other than XML.

> update category names for "Reloading configuration"
> ---------------------------------------------------
>
>                 Key: ARTEMIS-4909
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-4909
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Configuration
>    Affects Versions: 2.35.0
>            Reporter: Erwin Dondorp
>            Assignee: Erwin Dondorp
>            Priority: Minor
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> When the broker.xml file is reloaded, the following logfile messages are 
> produced:
> {noformat}
> 2024-07-07 20:30:08,138 INFO  [org.apache.activemq.artemis.core.server] 
> AMQ221056: Reloading configuration: security
> 2024-07-07 20:30:08,140 INFO  [org.apache.activemq.artemis.core.server] 
> AMQ221056: Reloading configuration: address settings
> 2024-07-07 20:30:08,143 INFO  [org.apache.activemq.artemis.core.server] 
> AMQ221056: Reloading configuration: diverts
> 2024-07-07 20:30:08,150 INFO  [org.apache.activemq.artemis.core.server] 
> AMQ221056: Reloading configuration: addresses
> [...]
> 2024-07-07 20:30:08,151 INFO  [org.apache.activemq.artemis.core.server] 
> AMQ221056: Reloading configuration: bridges
> 2024-07-07 20:30:08,151 INFO  [org.apache.activemq.artemis.core.server] 
> AMQ221056: Reloading configuration: protocol services
> {noformat}
> in would be more consistent when the actual top-level XML tags are mentioned 
> here as these are almost the same.
> and it closer matches the documentation, see 
> https://activemq.apache.org/components/artemis/documentation/latest/config-reload.html
> proposing:
> * security --> security-settings
> * address settings --> address-settings
> * diverts (already fine)
> * addresses (already fine)
> * bridges (already fine)
> * protocol services --> this part is not documented in 
> https://activemq.apache.org/components/artemis/documentation/latest/config-reload.html,
>  let's not touch that now.
> a PR is added.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact


Reply via email to