[
https://issues.apache.org/jira/browse/ARTEMIS-5110?focusedWorklogId=939313&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-939313
]
ASF GitHub Bot logged work on ARTEMIS-5110:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Oct/24 21:20
Start Date: 21/Oct/24 21:20
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #5303:
URL: https://github.com/apache/activemq-artemis/pull/5303#discussion_r1809555290
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java:
##########
@@ -1584,8 +1439,6 @@ void
noQueueIdDefined(org.apache.activemq.artemis.api.core.Message message,
@LogMessage(id = 224126, value = "Failure during protocol handshake on
connection to {} from {}", level = LogMessage.Level.ERROR)
void failureDuringProtocolHandshake(SocketAddress localAddress,
SocketAddress remoteAddress, Throwable e);
- // notice loggerID=224127 is reserved as it's been used at
ActiveMQQueueLogger
Review Comment:
Hmmm...I think `ActiveMQQueueLogger` should be modified so it's _not_
sharing the same ID space as `ActiveMQServerLogger` as that is going to
complicate things without obvious need.
Issue Time Tracking
-------------------
Worklog Id: (was: 939313)
Time Spent: 50m (was: 40m)
> Add ability to identify retired IDs in log annotations
> ------------------------------------------------------
>
> Key: ARTEMIS-5110
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5110
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The broker uses unique IDs for logging statements. As logging changes over
> time we need a way to "retire" these IDs (e.g. when certain logging
> statements are no longer needed) to ensure they are not used again in the
> future (or perhaps put back into the rotation after a certain amount of time).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
