[
https://issues.apache.org/jira/browse/ARTEMIS-5210?focusedWorklogId=948062&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-948062
]
ASF GitHub Bot logged work on ARTEMIS-5210:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Dec/24 16:18
Start Date: 12/Dec/24 16:18
Worklog Time Spent: 10m
Work Description: gemmellr commented on PR #5395:
URL:
https://github.com/apache/activemq-artemis/pull/5395#issuecomment-2539410499
I'm fine with the other changes, they make sense overall, but are only being
done due to the upgrade so it seems reaosonable enough to bundle them. I just
think the commented-out-code shouldnt be there, better nothing.
I did also type and delete 'maybe we could disable/downgrade-to-warning that
new check?' before suggesting just to delete the comment since I'm fine with
the changes. I'm also fine with duplicate branches where its clearer though, so
I'd be fine without the check also.
Issue Time Tracking
-------------------
Worklog Id: (was: 948062)
Time Spent: 1h 10m (was: 1h)
> Bump com.google.errorprone:error_prone_core from 2.31.0 to 2.36.0
> -----------------------------------------------------------------
>
> Key: ARTEMIS-5210
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5210
> Project: ActiveMQ Artemis
> Issue Type: Dependency upgrade
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
