[
https://issues.apache.org/jira/browse/ARTEMIS-5215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922669#comment-17922669
]
ASF subversion and git services commented on ARTEMIS-5215:
----------------------------------------------------------
Commit 1633b8bf7e605a7893d97ec8c8d6ff1ba7aac830 in activemq-artemis's branch
refs/heads/main from Timothy Bish
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=1633b8bf7e ]
ARTEMIS-5215 Credit handler reset in progress flag when stopped
When a pull mode federation consumer is stopped due to demand being
removed and the credit tup-up handler is also awaiting the Queue backlog
to clear in order to grant a new batch of credit it might exit that
cycle an leave the in-progress flag set to true. Currently this likely
won't trigger a stuck consumer but if the code was to be altered to hold
open a link for some period of time before fully closing in order to
avoid needless attach / detach cycles then it would be possible for the
credit replenishment to get stuck because the previous attempt left the
in-progress flag set to true.
> AMQP Federation Queue Consumer can leave a duplicate message on remote broker
> -----------------------------------------------------------------------------
>
> Key: ARTEMIS-5215
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5215
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: AMQP
> Affects Versions: 2.39.0
> Reporter: Timothy A. Bish
> Assignee: Timothy A. Bish
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.40.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> When local demand is removed from a federated Queue and the AMQP receiver is
> shutting down it needs to drain the link *and* await any pending settlements
> to be sent before detaching the link otherwise there is a window in which a
> message could be enqueued on the local broker but also released back to the
> queue on the remote leading to a duplicate.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
