[
https://issues.apache.org/jira/browse/ARTEMIS-5314?focusedWorklogId=958051&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-958051
]
ASF GitHub Bot logged work on ARTEMIS-5314:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 20/Feb/25 22:45
Start Date: 20/Feb/25 22:45
Worklog Time Spent: 10m
Work Description: tabish121 commented on code in PR #5512:
URL: https://github.com/apache/activemq-artemis/pull/5512#discussion_r1964119961
##########
tests/leak-tests/src/test/java/org/apache/activemq/artemis/tests/leak/PagingLeakTest.java:
##########
@@ -51,7 +51,9 @@
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assumptions.assumeTrue;
-/* at the time this test was written JournalFileImpl was leaking through
JournalFileImpl::negative creating a linked list (or leaked-list, pun intended)
*/
+/* At the time this test was written JournalFileImpl was leaking through
JournalFileImpl::negative creating a linked
Review Comment:
Could perhaps add a newline after the opening '/*' to bring this into
compliance with all the other formatting changes.
##########
tests/leak-tests/src/test/java/org/apache/activemq/artemis/tests/leak/JournalLeakTest.java:
##########
@@ -53,7 +53,9 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-/* at the time this test was written JournalFileImpl was leaking through
JournalFileImpl::negative creating a linked list (or leaked-list, pun intended)
*/
+/* At the time this test was written JournalFileImpl was leaking through
JournalFileImpl::negative creating a linked
Review Comment:
Should perhaps add a newline after the opening '/*' to be consistent with
other changes.
##########
artemis-commons/src/main/java/org/apache/activemq/artemis/json/JsonValue.java:
##########
@@ -57,10 +56,7 @@ public interface JsonValue {
String toString();
enum ValueType {
- ARRAY,
- OBJECT, STRING, NUMBER,
- TRUE, FALSE,
- NULL
+ ARRAY, OBJECT, STRING, NUMBER, TRUE, FALSE, NULL
Review Comment:
This doesn't appear to be javadoc related
Issue Time Tracking
-------------------
Worklog Id: (was: 958051)
Time Spent: 1h (was: 50m)
> overhaul JavaDoc formatting & content
> -------------------------------------
>
> Key: ARTEMIS-5314
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5314
> Project: ActiveMQ Artemis
> Issue Type: Task
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
