[
https://issues.apache.org/jira/browse/ARTEMIS-5053?focusedWorklogId=959851&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-959851
]
ASF GitHub Bot logged work on ARTEMIS-5053:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 03/Mar/25 20:41
Start Date: 03/Mar/25 20:41
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #5510:
URL: https://github.com/apache/activemq-artemis/pull/5510#discussion_r1978166188
##########
artemis-server/src/test/java/org/apache/activemq/artemis/core/config/impl/ConfigurationImplTest.java:
##########
@@ -962,6 +963,7 @@ private void
checkScaleDownConfiguration(ScaleDownConfiguration scaleDownConfigu
assertEquals("g0", scaleDownConfiguration.getGroupName());
assertEquals("c0", scaleDownConfiguration.getClusterName());
assertFalse(scaleDownConfiguration.isEnabled());
+ assertEquals(33, scaleDownConfiguration.getCommitInterval());
Review Comment:
a very tiny request.. can you use a different constant here? you used 33 on
the XML... if the XML is parsed by accident in the test you wouldn't know if
the value came from the XML or the properties.
If you okay with merging this now I can make this change myself with a git
checkout and push.
Issue Time Tracking
-------------------
Worklog Id: (was: 959851)
Time Spent: 1h (was: 50m)
> OOME during scaledown
> ---------------------
>
> Key: ARTEMIS-5053
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5053
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Clustering
> Affects Versions: 2.37.0
> Reporter: Emmanuel Hugonnet
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> When checking how scaledown behaves in WildFly we got an OOME when scaling
> down the node in messaging cluster. It seems to be trying to send all
> messages in [a single
> transaction|https://github.com/apache/activemq-artemis/blob/main/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ScaleDownHandler.java#L262-L319].
> More details [here|https://issues.redhat.com/browse/WFLY-19752].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
