[
https://issues.apache.org/jira/browse/AMQ-9685?focusedWorklogId=962411&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-962411
]
ASF GitHub Bot logged work on AMQ-9685:
---------------------------------------
Author: ASF GitHub Bot
Created on: 18/Mar/25 19:40
Start Date: 18/Mar/25 19:40
Worklog Time Spent: 10m
Work Description: cshannon commented on PR #1410:
URL: https://github.com/apache/activemq/pull/1410#issuecomment-2734523527
@graben - Ok I think you win, i made a proof of concept that catches the
error and cleans up the initialized destination in the store but the issue that
I realized is that there might be existing data that we could be blowing away
as it may not be a brand new destination. It would be too dangerous to assume
any error means we can just go dispose of the destination in the store as we
don't know the exact issue. In this case the error is fatal on creation, but
there could be lots of other interceptors that might have a more transient
error that could be recovered from.
In the grand scheme of things, your change is probably fine. The side effect
is if someone creates the wrong destination name with a missing virtual topic
name, it's not great but there's not really any harm other then you end up with
an extra destination with a typo and at least that is easily recovered from.
Issue Time Tracking
-------------------
Worklog Id: (was: 962411)
Time Spent: 1.5h (was: 1h 20m)
> Empty virtualName from broken queue name
> ----------------------------------------
>
> Key: AMQ-9685
> URL: https://issues.apache.org/jira/browse/AMQ-9685
> Project: ActiveMQ Classic
> Issue Type: Bug
> Components: Broker
> Affects Versions: 5.19.0, 6.1.6
> Reporter: Benjamin Graf
> Priority: Major
> Labels: error, virtualtopic
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Accidentally "invalid" queue name can lead to broken broker after throwing
> "{{Invalid destination name: a non-empty name is required}}"
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
