[
https://issues.apache.org/jira/browse/ARTEMIS-5511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17955686#comment-17955686
]
Andy Taylor commented on ARTEMIS-5511:
--------------------------------------
ok, in that case I think its fine not to refresh, will review the PR
> Improve rendering logic
> -----------------------
>
> Key: ARTEMIS-5511
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5511
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Web Console
> Reporter: Gašper Čefarin
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Came across this when trying to implement ARTEMIS-5424. The preferences for
> page size seem to be ignored.
> For every "tab" change: the ArtemisTable gets rendered 4 times (was testing
> queues tab), and the data from jolokia is fetched 2 times.
> After this PR, ArtemisTable is rendered 3 times "only" and the data is
> fetched only once.
> setPerPage does not seem to be necessary inside useEffect. I don't know yet
> where that is called, but pagination still works after this PR.
> The behavior is now slightly different when changing columns - the data does
> not get fetched/updated automatically after this PR.
> Would like to hear your opinions on this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
