[
https://issues.apache.org/jira/browse/AMQ-9721?focusedWorklogId=971687&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-971687
]
ASF GitHub Bot logged work on AMQ-9721:
---------------------------------------
Author: ASF GitHub Bot
Created on: 03/Jun/25 16:32
Start Date: 03/Jun/25 16:32
Worklog Time Spent: 10m
Work Description: cshannon opened a new pull request, #1447:
URL: https://github.com/apache/activemq/pull/1447
This fixes the broker so multiple removals are no longer done for the same
message leading to having to search the entire non persistent pending list.
Durable subscriptions now check the persistence type of the message so the
cursor will no longer search everything in a non-persistent pending list when
the message is persistent.
Since the fixes are primarily performance related it's a little bit tricky
to test but I added one new test for the durable sub cursor removal and the
existing tests should cover everything else including memory usage being
correct (such as the test added recently in AMQ-9698)
Issue Time Tracking
-------------------
Worklog Id: (was: 971687)
Remaining Estimate: 0h
Time Spent: 10m
> Fix performance issues with message removal from topic and durable
> subscriptions
> --------------------------------------------------------------------------------
>
> Key: AMQ-9721
> URL: https://issues.apache.org/jira/browse/AMQ-9721
> Project: ActiveMQ Classic
> Issue Type: Bug
> Affects Versions: 6.1.6, 5.18.7
> Reporter: Christopher L. Shannon
> Assignee: Christopher L. Shannon
> Priority: Major
> Fix For: 6.2.0, 5.19.1, 6.1.7
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> While testing various scenarios with expiration on subscriptions I noticed
> that when there is a large backlog of non-persistent messages the CPU usage
> would spike in some cases for removing messages. This only happened when non
> persistent messages were using the pending disk list and not in memory.
> After investigation, it turns out there are a couple of problems that need to
> be resolved.
> # FilePendingMessageCursor flushes messages to disk when memory is full. The
> disk cursor uses a linked list as an index which has O\(n) performance for
> random access. This is not an issue because the broker is going to append
> messages to the front/end and then page them in from the front for dispatch,
> expire, discard, etc. Except...it turns out in a couple spots the broker is
> actually incorrectly calling remove twice on the cursor for the same message.
> (Happens on discard for topic subs, also during expiration for durable subs).
> Usually when remove is called it finds the message pretty quickly as it was
> recently dispatched or paged in, except since it's called twice it iterates
> over the entire linked list for no reason and finds nothing. This causes a
> huge performance problem if there's a large backup (ie millions)
> # The second problem is specific to durable subscriptions. The durable sub
> cursor contains a list of cursors for its topic stores and also for it's
> non-persistent cursor. The problem is that when the expiration task runs and
> calls the remove method, it is being delegated to all cursors, including non
> persistent. So even though it will never find the message in the cursor if
> there's a huge non-persistent backlog it causes a lot of CPU usage to search.
> This can be fixed by checking the persistent type and only calling the right
> prefetches for remove, similar to how the add method works and how queue
> subscriptions work.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
