[
https://issues.apache.org/jira/browse/AMQ-9719?focusedWorklogId=971808&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-971808
]
ASF GitHub Bot logged work on AMQ-9719:
---------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jun/25 12:59
Start Date: 04/Jun/25 12:59
Worklog Time Spent: 10m
Work Description: cshannon commented on code in PR #1445:
URL: https://github.com/apache/activemq/pull/1445#discussion_r2126540488
##########
activemq-client/src/main/java/org/apache/activemq/filter/XPathExpression.java:
##########
@@ -120,17 +120,6 @@ protected static void setupFeatures(DocumentBuilderFactory
factory) {
}
}
}
- if (features.size() > 0) {
Review Comment:
Instead of removing this, I think it makes more sense to add an actual log
statement (probably debug level) as based on the comment that was the intent of
the loop. If we did that we should probably do a check to see if the log level
is enabled before doing the actual iteration and building of the buffer to
avoid the performance hit if not logging of building the string. I would also
switch to using StringBuilder as well.
Issue Time Tracking
-------------------
Worklog Id: (was: 971808)
Time Spent: 20m (was: 10m)
> Two StringBuffers are updated, but the value isn't used
> -------------------------------------------------------
>
> Key: AMQ-9719
> URL: https://issues.apache.org/jira/browse/AMQ-9719
> Project: ActiveMQ Classic
> Issue Type: Bug
> Reporter: Dmitrii Kriukov
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Sample:
> line 124 in XPathExpression
> StringBuffer featureString = new StringBuffer();
> I will provide a PR
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
