[
https://issues.apache.org/jira/browse/ARTEMIS-5535?focusedWorklogId=972717&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-972717
]
ASF GitHub Bot logged work on ARTEMIS-5535:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jun/25 04:23
Start Date: 12/Jun/25 04:23
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #5772:
URL: https://github.com/apache/activemq-artemis/pull/5772#discussion_r2141685863
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQClientProtocolManager.java:
##########
@@ -499,8 +500,7 @@ public void handlePacket(final Packet packet) {
private void handleDisconnect(SimpleString nodeID, DisconnectReason
reason, SimpleString targetNodeID, TransportConfiguration tagetConnector) {
if (topologyResponseHandler != null) {
- topologyResponseHandler.nodeDisconnected(conn, nodeID == null ?
null : nodeID.toString(), reason,
- targetNodeID == null ? null : targetNodeID.toString(),
tagetConnector);
+ topologyResponseHandler.nodeDisconnected(conn,
Objects.toString(nodeID), reason, Objects.toString(targetNodeID),
tagetConnector);
Review Comment:
I'll use `Objects.toString(String, null)` to keep the same semantics.
Issue Time Tracking
-------------------
Worklog Id: (was: 972717)
Time Spent: 40m (was: 0.5h)
> Use Objects.toString() instead of ternary operator
> --------------------------------------------------
>
> Key: ARTEMIS-5535
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5535
> Project: ActiveMQ Artemis
> Issue Type: Task
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> There are lots of places across the code-base which do a check like this:
> {code:java}
> foo != null ? foo.toString() : null{code}
> or
> {code:java}
> foo == null ? null : foo.toString(){code}
> These can be replaced, e.g.:
> {code:java}
> Objects.toString(foo){code}
> This code is more clear and will make the code-base more consistent overall.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
