[
https://issues.apache.org/jira/browse/ARTEMIS-5536?focusedWorklogId=972785&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-972785
]
ASF GitHub Bot logged work on ARTEMIS-5536:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jun/25 14:12
Start Date: 12/Jun/25 14:12
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #5760:
URL: https://github.com/apache/activemq-artemis/pull/5760#discussion_r2142882176
##########
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq/AMQConsumer.java:
##########
@@ -528,7 +592,10 @@ public void removeRolledback(MessageReference
messageReference) {
}
public void addRolledback(MessageReference messageReference) {
- currentWindow.decrementAndGet();
+ // NOte:
Review Comment:
Note::
(typo on the comment)
Issue Time Tracking
-------------------
Worklog Id: (was: 972785)
Time Spent: 20m (was: 10m)
> Openwire Flowcontrol Hardening
> ------------------------------
>
> Key: ARTEMIS-5536
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5536
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> - AMQConsumer will discount credits ahead of taking them on rollback, that
> would lead to negative values
> - AMQConsumer.close() is blocking an operation
> - fixing other branches for flow control
> This is fixing RedeliveryPolicyTest.testCanRollbackPastPrefetch and improving
> reliability in other openwire tests
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
