[
https://issues.apache.org/jira/browse/ARTEMIS-5364?focusedWorklogId=973042&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-973042
]
ASF GitHub Bot logged work on ARTEMIS-5364:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jun/25 16:21
Start Date: 24/Jun/25 16:21
Worklog Time Spent: 10m
Work Description: brusdev commented on code in PR #5578:
URL: https://github.com/apache/activemq-artemis/pull/5578#discussion_r2164428109
##########
tests/smoke-tests/src/test/java/org/apache/activemq/artemis/tests/smoke/upgradeTest/CompareUpgradeTest.java:
##########
@@ -212,10 +211,7 @@ public void testWindows() throws Exception {
"set ARTEMIS_HOME=", null, // no expected
value for this, we will check on the output
"set ARTEMIS_INSTANCE=", "\"" + windows +
"\"",
"set ARTEMIS_DATA_DIR=", "\"" + windowsData
+ "\"",
- "set ARTEMIS_ETC_DIR=", "\"" + windowsETC +
"\"",
- "set ARTEMIS_OOME_DUMP=", "\"" + windows +
"/log/oom_dump.hprof\"",
Review Comment:
Is the check for `ARTEMIS_OOME_DUMP` removed on purpose for windowsETC +
"/artemis.profile.cmd"?
##########
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/Create.java:
##########
@@ -930,12 +930,10 @@ protected static void addScriptFilters(Map<String,
String> filters,
// so that's just to make a distinction
filters.put("@artemis.instance@", path(directory));
filters.put("${artemis.instance.uri}", directory.toURI().toString());
- filters.put("${artemis.instance.uri.windows}",
directory.toURI().toString().replaceAll("%", "%%"));
Review Comment:
Is `artemis.instance.uri` still used?
Issue Time Tracking
-------------------
Worklog Id: (was: 973042)
Time Spent: 20m (was: 10m)
> Clean up scripts & profiles
> ---------------------------
>
> Key: ARTEMIS-5364
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5364
> Project: ActiveMQ Artemis
> Issue Type: Task
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The Linux & Windows scripts and their corresponding profile files each have
> variables and other content that's no longer useful and/or necessary. This
> content should be removed to simplify the files and to make them easier to
> read & understand.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
