[
https://issues.apache.org/jira/browse/ARTEMIS-5519?focusedWorklogId=973041&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-973041
]
ASF GitHub Bot logged work on ARTEMIS-5519:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jun/25 16:18
Start Date: 24/Jun/25 16:18
Worklog Time Spent: 10m
Work Description: tabish121 commented on code in PR #5793:
URL: https://github.com/apache/activemq-artemis/pull/5793#discussion_r2164429804
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/ProtonProtocolManager.java:
##########
@@ -237,26 +237,30 @@ public ProtonClientProtocolManager createClientManager() {
@Override
public ConnectionEntry createConnectionEntry(Acceptor acceptorUsed,
Connection remotingConnection) {
- return internalConnectionEntry(remotingConnection, false, null, null);
+ return internalConnectionEntry(remotingConnection, false, null, null,
null, null);
}
/**
* This method is not part of the ProtocolManager interface because it only
makes sense on AMQP. More specifically on
* AMQP Bridges
*/
public ConnectionEntry createOutgoingConnectionEntry(Connection
remotingConnection) {
- return internalConnectionEntry(remotingConnection, true, null, null);
+ return internalConnectionEntry(remotingConnection, true, null, null,
null, null);
}
public ConnectionEntry createOutgoingConnectionEntry(Connection
remotingConnection, ClientSASLFactory saslFactory) {
- return internalConnectionEntry(remotingConnection, true, saslFactory,
null);
+ return internalConnectionEntry(remotingConnection, true, saslFactory,
null, null, null);
}
public ConnectionEntry createOutgoingConnectionEntry(Connection
remotingConnection, ClientSASLFactory saslFactory, Map<Symbol, Object>
connectionProperties) {
- return internalConnectionEntry(remotingConnection, true, saslFactory,
connectionProperties);
+ return internalConnectionEntry(remotingConnection, true, saslFactory,
connectionProperties, null, null);
}
- private ConnectionEntry internalConnectionEntry(Connection
remotingConnection, boolean outgoing, ClientSASLFactory saslFactory,
Map<Symbol, Object> connectionProperties) {
+ public ConnectionEntry createOutgoingConnectionEntry(Connection
remotingConnection, ClientSASLFactory saslFactory, Map<Symbol, Object>
connectionProperties, Symbol[] offeredCapabilities, Symbol[]
desiredCapabilities) {
+ return internalConnectionEntry(remotingConnection, true, saslFactory,
connectionProperties, offeredCapabilities, desiredCapabilities);
Review Comment:
Yep, forgot to back that out.
Issue Time Tracking
-------------------
Worklog Id: (was: 973041)
Time Spent: 20m (was: 10m)
> Enable AMQP Bridge address receiver to use shared durable subscriptions
> -----------------------------------------------------------------------
>
> Key: ARTEMIS-5519
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5519
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: AMQP
> Affects Versions: 2.41.0
> Reporter: Timothy A. Bish
> Assignee: Timothy A. Bish
> Priority: Minor
> Labels: pull-request-available
> Fix For: 2.42.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> If a broker reports that it supports shared durable subscriptions the AMQP
> bridge address receiver could use those types of subscriptions to avoid a
> potential corner case where many rapid cycles of consumer demand being added
> and removed can lead to a race on processing the detach frame and allow the
> previous link to be stolen right before it is remotely closed. This corner
> case does not happen in most scenarios due to the presence of the link credit
> drain out and the idle link keep alive delay but depending on those
> configurations it is still possible. By default this patch does not switch
> to always using shared subscriptions as that can leave an orphaned durable
> queue if already using durable address subscriptions but we can eventually
> move that direction in a major version update.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
