[
https://issues.apache.org/jira/browse/AMQ-9732?focusedWorklogId=973410&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-973410
]
ASF GitHub Bot logged work on AMQ-9732:
---------------------------------------
Author: ASF GitHub Bot
Created on: 01/Jul/25 05:09
Start Date: 01/Jul/25 05:09
Worklog Time Spent: 10m
Work Description: jbonofre commented on PR #1461:
URL: https://github.com/apache/activemq/pull/1461#issuecomment-3021794108
@grigoni yes I started to review it. Generally speaking, I'm not a big fan
of large PR for code cleanup (when generated by tool or not). It's long to
review (it touches different part of the code) and side effects can happen (for
instance, using a not expected locale, ...).
So, instead of a super large PR changing everything at once, I would split
into smaller chuncks.
That said for this PR, at first glance, it looks good, but I still have to
do a new pass.
Issue Time Tracking
-------------------
Worklog Id: (was: 973410)
Time Spent: 20m (was: 10m)
> More Code cleanup: use StringBuilder instead of StringBuffer
> ------------------------------------------------------------
>
> Key: AMQ-9732
> URL: https://issues.apache.org/jira/browse/AMQ-9732
> Project: ActiveMQ Classic
> Issue Type: Improvement
> Reporter: Gianandrea Rigoni
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> second round about StringBuffer usage
> use StringBuilder instead of StringBuffer: this avoids unnecessary sync
> use StringBuilder best practice when concatenating
> avoid concatenation in logging
> some typo fixing
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
