[ 
https://issues.apache.org/jira/browse/ARTEMIS-5530?focusedWorklogId=978696&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-978696
 ]

ASF GitHub Bot logged work on ARTEMIS-5530:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/Aug/25 09:44
            Start Date: 13/Aug/25 09:44
    Worklog Time Spent: 10m 
      Work Description: AntonRoskvist commented on PR #5867:
URL: 
https://github.com/apache/activemq-artemis/pull/5867#issuecomment-3183031316

   I think this pretty much did it, except for one remaining issue: 
   
   Yesterday I made a change to the test 
`testUpstreamFederatedAddressWithCompressedMessage` [link 
here](https://github.com/AntonRoskvist/activemq-artemis/commit/fbae046a48707229a4927288105c6a618446eabb).
 Where I added federation of two more messages. One regular message and one 
regular that's been compressed. The latter fails to federate.
   
   I'm able to get it working by removing two lines in 
`ClientConsumerImpl.handleCompressedMessageSentAsRegular(..)`
   ```
   largeMessage.putBooleanProperty(Message.HDR_LARGE_COMPRESSED, false);
   //make sure the message is decompressed before it is handled
   largeMessage.checkCompletion();
   ```
    
    I am not seeing any side effects of this at the moment, though I see the 
call to `checkCompletion()` was added as part of the recent #5867
    
    I'm currently doing some more testing




Issue Time Tracking
-------------------

    Worklog Id:     (was: 978696)
    Time Spent: 2h 50m  (was: 2h 40m)

> Some handling of compressed messages can throw NegativeArraySizeException
> -------------------------------------------------------------------------
>
>                 Key: ARTEMIS-5530
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-5530
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Anton Roskvist
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> Federating compressed messages causes this for example.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to