[
https://issues.apache.org/jira/browse/AMQ-9769?focusedWorklogId=985186&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-985186
]
ASF GitHub Bot logged work on AMQ-9769:
---------------------------------------
Author: ASF GitHub Bot
Created on: 30/Sep/25 13:59
Start Date: 30/Sep/25 13:59
Worklog Time Spent: 10m
Work Description: thezbyg commented on PR #1493:
URL: https://github.com/apache/activemq/pull/1493#issuecomment-3352325553
Done, but now ConnectionView returns the same value for both `getClientId`
and `getConnectionId`:
```
public String getClientId() {
return connection.getConnectionId();
}
public String getConnectionId() {
return connection.getConnectionId();
}
```
And `connection.getConnectionId()` executes the following code in
TransportConnection class:
```
public String getConnectionId() {
List<TransportConnectionState> connectionStates =
listConnectionStates();
for (TransportConnectionState cs : connectionStates) {
if (cs.getInfo().getClientId() != null) {
return cs.getInfo().getClientId();
}
return cs.getInfo().getConnectionId().toString();
}
return null;
}
```
So it may return either `clientId` or `connectionId`.
I propose to remove connection handling changes from this pull request and
keep only changes to connector MBean and connector output in web UI.
Issue Time Tracking
-------------------
Worklog Id: (was: 985186)
Time Spent: 1h 20m (was: 1h 10m)
> Add name property to connector interface and MBean
> --------------------------------------------------
>
> Key: AMQ-9769
> URL: https://issues.apache.org/jira/browse/AMQ-9769
> Project: ActiveMQ Classic
> Issue Type: Improvement
> Components: Broker, Web Console
> Reporter: Albertas Vyšniauskas
> Assignee: Jean-Baptiste Onofré
> Priority: Minor
> Fix For: 6.2.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> {color:#000000}{color:#000000}ConnectorViewMBean{color}{color} does not have
> a name property and the only way to get connector name from MBean is
> "connectorName" JMX value. This is bad because JMX values are escaped and
> this escaping is non-reversible, so it is impossible to get the original
> connector name.
> Web console could use this new name property to show original connector name
> instead of the one mangled by JMX escaping.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
