[ 
https://issues.apache.org/jira/browse/ARTEMIS-5683?focusedWorklogId=985543&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-985543
 ]

ASF GitHub Bot logged work on ARTEMIS-5683:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Oct/25 20:14
            Start Date: 02/Oct/25 20:14
    Worklog Time Spent: 10m 
      Work Description: brusdev commented on code in PR #5948:
URL: https://github.com/apache/activemq-artemis/pull/5948#discussion_r2399953172


##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/LegacyLDAPSecuritySettingPlugin.java:
##########
@@ -482,6 +541,14 @@ private void processSearchResult(Map<String, Set<Role>> 
securityRoles,
       }
    }
 
+   private String convertDestinationWildcards(String destination) {
+      // Convert the OpenWire wildcard syntax to the corresponding Artemis 
syntax
+      destination = OPENWIRE_WILDCARD.convert(destination, 
wildcardConfiguration);
+      // The '$' character was used previously in LDAP entries to represent 
the '>' character
+      destination = destination.replace('$', 
wildcardConfiguration.getAnyWords());

Review Comment:
   Nevermind I was wrong





Issue Time Tracking
-------------------

    Worklog Id:     (was: 985543)
    Time Spent: 1.5h  (was: 1h 20m)

> Properly convert wildcards in LegacyLDAPSecuritySettingPlugin
> -------------------------------------------------------------
>
>                 Key: ARTEMIS-5683
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-5683
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Justin Bertram
>            Assignee: Justin Bertram
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> Classic supports translating {{$}} into {{<}} for wildcards in its 
> [{{SimpleCachedLDAPAuthorizationMap}}|https://github.com/apache/activemq/blob/f68fff981b5a7b62a68b8c2f4ef01c73cf2d3404/activemq-broker/src/main/java/org/apache/activemq/security/SimpleCachedLDAPAuthorizationMap.java#L588].
>  The corresponding {{LegacyLDAPSecuritySettingPlugin}} in Artemis should do 
> the same.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to