[
https://issues.apache.org/jira/browse/ARTEMIS-5701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18030759#comment-18030759
]
Robbie Gemmell commented on ARTEMIS-5701:
-----------------------------------------
I'd agree that artemis-junit-5 using junit 6 is a bit weird.
Dependabot proposed a PR to just bump the version originally, then Justin
created another PR making some other changes, and then after some feedback I
created the third and final PR to do some things differently and fix some
related issues between the main build and examples. I actually forgot that
artemis-junit-4/5 exists in all of those, as probably did Justin, as the build
doesnt use it anywhere outside that module itself. I frankly think a lot of its
API is a poor fit for how things should be used in tests, especially so on the
client side of things where it doenst even cater to the things most of the
tests do or client most users use. I'd happily delete them if noone objected.
All that said though.... Artemis has required Java 17 since 2.39.0 back in
2024. So that part wasnt by accident and it certainly wasnt a new requirement
here at all, it was totally independent from the recent junit 6 change.
I guess we could go back to specifying a version of junit 5 on artemis-junit-5
specifically, even though we use 6 almost everywhere else, however silly that
in itself is.
For now, if you were to manage the specific version of junit used in your own
build, then I'd half expect you can just say you want 5 and have it work,
rather than relying on some unknown transitive junit version coming in. Unclear
how the Java 17 thing would cause you any issues at all between 2.42.0 and
2.43.0 when Artemis 2.42.0 already required Java 17, maybe thats just something
you also noted when being surprised by junit 6 being there.
> 2.43.0 broke backward compatibility
> -----------------------------------
>
> Key: ARTEMIS-5701
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5701
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.43.0
> Reporter: Jonatan Ivanov
> Priority: Blocker
>
> In 2.43.0, the JUnit version was upgraded from 5.x to 6.x, see:
> [https://github.com/apache/activemq-artemis/commit/615367d53fb1d21b5eae50b4e2c66c45c8a2b42d]
> and https://issues.apache.org/jira/browse/ARTEMIS-5591
> Also:
> https://repo1.maven.org/maven2/org/apache/activemq/artemis-project/2.42.0/artemis-project-2.42.0.pom
> and
> https://repo1.maven.org/maven2/org/apache/activemq/artemis-project/2.43.0/artemis-project-2.43.0.pom.
> This results in {{org.apache.activemq:artemis-junit-5}} not using JUnit 5
> anymore which is weird since its name explicitely says it's for JUnit 5 but
> most importantly, JUnit 6 increased the Java baseline to 17 (totally fine, it
> was a major version). This means that Artemis also increased the Java
> baseline but in a minor release for dependencies that bring in JUnit
> transitively. Not sure what is the version strategy of the project but both
> of these are quite unexpected, see:
> [https://github.com/micrometer-metrics/micrometer/pull/6807]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
