[
https://issues.apache.org/jira/browse/ARTEMIS-5745?focusedWorklogId=990640&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-990640
]
ASF GitHub Bot logged work on ARTEMIS-5745:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Nov/25 22:40
Start Date: 06/Nov/25 22:40
Worklog Time Spent: 10m
Work Description: jbertram commented on PR #6027:
URL:
https://github.com/apache/activemq-artemis/pull/6027#issuecomment-3499685641
> ...for me it's not about "needing" the extra performance, it's about
having the option.
Why would you want to have the option if you don't need the extra
performance (assuming the main use-case here really is related to performance)?
> I'm not sure what you mean by statistically significant differences...
I mean a meaningful, measurable difference for a real-world use-case. For
example, 10% faster average load times for the web console using the default
configuration, 20% faster load times for the web console in high-load
uses-cases (e.g. lots of addresses & queues), etc. Something like a 2-3%
increase probably isn't worth the additional complexity (i.e. technical debt)
here.
> I'm sure a number of cases could be made for decoupling messaging traffic
from web traffic, and for security.
What kind of decoupling did you have in mind? Messaging traffic is handled
via Netty by the Core broker which is already separate from web traffic, which
is handled by the embedded Jetty instance. Both use independent thread pools.
Also, traffic for each goes over different ports and potentially even different
network interfaces.
Can you elaborate on the security aspect here?
> We're probably looking at this from very different perspectives :)
That's certainly possible. Since you specifically [solicited opinions in the
description of the Jira](https://issues.apache.org/jira/browse/ARTEMIS-5745) I
figured I'd jump in.
I'm always trying to better understand how folks use the broker, and I'm not
super familiar with Unix domain sockets so I'm keen to learn about the use-case
here. Aside from that I'd like to reduce complexity and technical debt where it
makes sense. I don't want to fall into [premature
optimization](https://www.geeksforgeeks.org/software-engineering/premature-optimization/).
Issue Time Tracking
-------------------
Worklog Id: (was: 990640)
Time Spent: 1h (was: 50m)
> Add support for exposing jetty on unix sockets
> ----------------------------------------------
>
> Key: ARTEMIS-5745
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5745
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Affects Versions: 2.44.0
> Reporter: Gašper Čefarin
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> I'd like to add support for unix sockets.
> The code in the PR is open to adjustments, since this is just a "proof of
> concept" so to say, and a lot of things are not as elegant as I'd like them
> to be. I want to hear your opinions first.
>
> There's 1 major change, and that's the removal of virtual hosts, and removal
> of connector names.
> From what I understand, virtual host names should match connector names for
> jetty "routing" to work - but this only works for http and https connectors,
> not for unix sockets.
> I had the issue of unix socket being created but the /console URL returning
> 404 - and the issue was resolved when I changed this code:
> {code:java}
> webapp.setVirtualHosts(new String[]{virtualHost}){code}
> to this:
> {code:java}
> webapp.setVirtualHosts(null);{code}
> I've had some help from AI, otherwise I couldn't find the source of the 404
> "error":
> _"Using null for virtual hosts makes the context respond to all connectors,
> including Unix domain sockets."_
> Since all connector names were added to virtualHost array, and all virtual
> hosts were added to all contexts, the functionality should be the same after
> this change ... Please correct me if I'm wrong.
> You can test this PR by adding this into bootstrap.xml:
> {code:java}
> <binding name="artemis" uri="unix:///tmp/jetty.sock">
> <app name="console" url="console" war="console.war"/>
> </binding>{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
