[
https://issues.apache.org/jira/browse/ARTEMIS-5753?focusedWorklogId=990792&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-990792
]
ASF GitHub Bot logged work on ARTEMIS-5753:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Nov/25 21:37
Start Date: 07/Nov/25 21:37
Worklog Time Spent: 10m
Work Description: clebertsuconic opened a new pull request, #6037:
URL: https://github.com/apache/activemq-artemis/pull/6037
Older versions (2.33.0) had a possible race where PageCompletes could be
marked while the entire set of files is removed. What could cause message loss.
Say you had 100 pages and they were all removed right after failback. The
next file written could be on a lower sequence than the latest one and you
would have future PageCompletes.
This is not happening on current versions, but this would be the proper
defense if this happened.
This is also a good fix to be cherry-picked into previous branches.
Issue Time Tracking
-------------------
Worklog Id: (was: 990792)
Remaining Estimate: 0h
Time Spent: 10m
> Paging has the possibility on losing messages during failback in older
> versions (before 2.33)
> ---------------------------------------------------------------------------------------------
>
> Key: ARTEMIS-5753
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5753
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.33.0
> Reporter: Clebert Suconic
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.45.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We recently changed the paging thread model to be single threaded, so recent
> versions are not affected by this.
> 2.33 and before could get into a race where Pages are marked as complete and
> the entire set of files removed, future written pages would then be marked as
> complete and these messages wouldn't be delivered.
> This happened during failback on the reports I had seen, and on my tests.
> I couldn't reproduce this on latest versions, and that's consistent with the
> new threading model.
> I am adding a UnitTest introducing the exact conditon that would cause the
> loss on the latest version and still applying a defense in case it happened,
> just to be safe.
> I am also applying some extra cleanup on Acks in case the page files are not
> present, to prevent any possible loss.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
