[ 
https://issues.apache.org/jira/browse/ARTEMIS-5746?focusedWorklogId=990952&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-990952
 ]

ASF GitHub Bot logged work on ARTEMIS-5746:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/Nov/25 13:20
            Start Date: 10/Nov/25 13:20
    Worklog Time Spent: 10m 
      Work Description: brusdev commented on code in PR #6028:
URL: https://github.com/apache/activemq-artemis/pull/6028#discussion_r2510541714


##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/server/ConfigurationTest.java:
##########
@@ -211,6 +211,56 @@ public void testPropertiesOnlyConfigReload() throws 
Exception {
       }
    }
 
+   @Test
+   public void testPropertiesDirWithFilterConfigReloadOnNewFile() throws 
Exception {

Review Comment:
   Can you also test that a file not matching the filter doesn't affect the 
reloaded configuration? 





Issue Time Tracking
-------------------

    Worklog Id:     (was: 990952)
    Time Spent: 0.5h  (was: 20m)

> brokerProperties - allow configuration of the filter for directory urls
> -----------------------------------------------------------------------
>
>                 Key: ARTEMIS-5746
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-5746
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Configuration
>    Affects Versions: 2.44.0
>            Reporter: Gary Tully
>            Assignee: Gary Tully
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 2.45.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The properties url can end in a / to indicate that all files in that 
> directory should be considered as properties.
> there is a hard-coded filter, .json|.properties but this is a little too 
> restrictive. It would be nice for users to be able to use .props or whatever 
> filter regex makes sense for an existing directory.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to