[
https://issues.apache.org/jira/browse/ARTEMIS-5750?focusedWorklogId=991731&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-991731
]
ASF GitHub Bot logged work on ARTEMIS-5750:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Nov/25 14:44
Start Date: 14/Nov/25 14:44
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #6066:
URL: https://github.com/apache/activemq-artemis/pull/6066#discussion_r2527762683
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingStoreImpl.java:
##########
@@ -1398,6 +1432,28 @@ public int page(Message message,
return -1;
}
+ boolean diskFull = pagingManager.isDiskFull();
+
+ if (diskFullMessagePolicy != null && diskFullMessagePolicy !=
DiskFullMessagePolicy.BLOCK) {
Review Comment:
I got confused on this part here... why not have diskFullMessagePolicy ==
FAIL?
Issue Time Tracking
-------------------
Worklog Id: (was: 991731)
Time Spent: 20m (was: 10m)
> Add an address disk-full-policy configuration parameter that will define the
> message policy when the disk space limit is reached.
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: ARTEMIS-5750
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5750
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Reporter: Iliya Grushevskiy
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Implement an address configuration parameter disk-full-policy, that will
> DROP, FAIL or BLOCK producer message flow when disk limits are reached. By
> default, it will BLOCK to maintain the current behavior.
> Currently, if address paging is enabled the default behavior is to always
> BLOCK the producer. This can be an undesirable behavior for clients, which
> should fail quickly on any send failure and switch to another broker.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
