[
https://issues.apache.org/jira/browse/ARTEMIS-5763?focusedWorklogId=992393&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-992393
]
ASF GitHub Bot logged work on ARTEMIS-5763:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Nov/25 10:15
Start Date: 19/Nov/25 10:15
Worklog Time Spent: 10m
Work Description: gtully commented on code in PR #6067:
URL: https://github.com/apache/activemq-artemis/pull/6067#discussion_r2541358770
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/PrimaryOnlyActivation.java:
##########
@@ -67,6 +67,10 @@ public PrimaryOnlyPolicy getPrimaryOnlyPolicy() {
@Override
public void run() {
try {
+ if
(activeMQServer.getConfiguration().getConfigurationFileRefreshPeriod() > 0) {
Review Comment:
I think ideally it would need to be tied into the reload manager, but that
is not started till later.
I guess a simple check to verify that the current time is > startup +
refresh period would cover it. good idea.
it depends though on when startup time is set! I will investigate. thanks
Issue Time Tracking
-------------------
Worklog Id: (was: 992393)
Time Spent: 50m (was: 40m)
> reload config on primary activation after lock acquisition
> ----------------------------------------------------------
>
> Key: ARTEMIS-5763
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5763
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: 2.44.0
> Reporter: Gary Tully
> Assignee: Gary Tully
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.45.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> If a broker is waiting for an activation shared lock, and configuration is
> updated while waiting, the files are not reloaded on start.
> the lastmodified is calculated on activation, but the config has been loaded
> on initial startup so it can be stale.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
