[
https://issues.apache.org/jira/browse/AIRAVATA-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15816178#comment-15816178
]
Marcus Christie commented on AIRAVATA-1397:
-------------------------------------------
Why is there a 'server-allowed-file-size' variable in pga_config.php? Is this
just supposed to be the same as 'upload_max_filesize' in php.ini? If so, we
don't need that since we can get the value from php.ini.
Currently we have a bit of JavaScript that checks to see if files selected for
upload are greater than the minimum of post_max_size and
'server-allowed-file-size'. However,
* I would propose getting right of 'server-allowed-file-size' and instead look
at the minimum of upload_max_filesize and post_max_size
* it wasn't set up for the optional input files but I've fixed that locally
That catches this problem earlier, client side. Here are some other
improvements that I think can be made
# Display the max upload file size in the form so that users (and
administrators) have some clue as to what the max file size is.
# Determine server side if the upload_max_filesize has been exceeded and
redisplay the experiment creation form with an error message.
# Determine server side if the post_max_size has been exceeded. Not sure what
can be done in this case since it looks like $_POST is empty. We can redisplay
the form with an error but the values provided by the user will be completely
empty.
With the client side detection, I'm not sure how important #2 and #3 are. Since
there isn't much that can be really be done with #3, I don't think it is worth
it. I think #2 is worth it however, since you can't always rely on client side
JavaScript.
> PGA gateway needs to gracefully handle attempts to upload files that are too
> large.
> -----------------------------------------------------------------------------------
>
> Key: AIRAVATA-1397
> URL: https://issues.apache.org/jira/browse/AIRAVATA-1397
> Project: Airavata
> Issue Type: Improvement
> Reporter: Marlon Pierce
> Assignee: Marcus Christie
> Fix For: 0.17
>
>
> This is mostly a PHP problem. File upload limits are specified in the
> php.ini file (typically, /etc/php.ini). The parameters upload_max_filesize
> and post_max_size need to be modified to increase the size.
> If post_max_size is exceeded, the operation will fail silently: PHP doesn't
> complain, and PGA will not call the airavata clients. If upload_max_filesize
> is exceeded but not the post size limit, you will get errors. It is
> advisable to change both (as documented in the PGA's README.md file) and to
> keep both the same value.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
