[
https://issues.apache.org/jira/browse/AIRAVATA-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16041350#comment-16041350
]
ASF GitHub Bot commented on AIRAVATA-2385:
------------------------------------------
Github user machristie commented on a diff in the pull request:
https://github.com/apache/airavata/pull/111#discussion_r120700426
--- Diff:
airavata-services/profile-service/profile-service-server/src/main/java/org/apache/airavata/service/profile/handlers/TenantProfileServiceHandler.java
---
@@ -72,7 +72,9 @@ public String getAPIVersion(AuthzToken authzToken) throws
TenantProfileServiceEx
@SecurityCheck
public String addGateway(AuthzToken authzToken, Gateway gateway)
throws TenantProfileServiceException, AuthorizationException, TException {
try {
- gateway = tenantProfileRepository.create(gateway);
+ if (!checkDuplicate(gateway)) {
--- End diff --
If there is a duplicate then I think the code should throw a
TenantProfileServiceException with an error message explaining that there is a
duplicate.
> SciGaP portal need to check for duplicating gateway names and URLs at the
> time of user creating/submitting the gateway request.
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: AIRAVATA-2385
> URL: https://issues.apache.org/jira/browse/AIRAVATA-2385
> Project: Airavata
> Issue Type: Improvement
> Components: PGA PHP Web Gateway
> Affects Versions: 0.17
> Reporter: Eroma
> Assignee: Sneha Tilak
> Fix For: 0.18
>
>
> Currently wt the time of creating or submitting the request this is not
> checked.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
