[
https://issues.apache.org/jira/browse/AIRAVATA-2279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16238405#comment-16238405
]
ASF GitHub Bot commented on AIRAVATA-2279:
------------------------------------------
machristie commented on a change in pull request #75: [AIRAVATA-2279 & 2280]
FIXED.
URL:
https://github.com/apache/airavata-php-gateway/pull/75#discussion_r148895633
##########
File path: app/views/admin/manage-credentials.blade.php
##########
@@ -113,34 +134,38 @@ class="sr-only">Close</span></button>
<img src="../../assets/ajax-loader.gif"/>
</div>
@endif
- <table class="table table-bordered table-condensed"
style="word-wrap: break-word;">
- <tr>
- <th class="text-center">
- Token
- </th>
- <th class="text-center">Description</th>
- @if( Session::has("admin"))
- <th>Delete</th>
- @endif
- </tr>
- <tbody class="token-values">
- @foreach( $pwdTokens as $token => $publicKey)
- <tr>
- <td class="">
- {{ $token }}
- </td>
- <td class="description">
- {{ $publicKey }}
- </td>
- @if( Session::has("admin"))
- <td>
- <span data-token="{{$token}}"
class="glyphicon glyphicon-trash remove-pwd-token"></span>
- </td>
- @endif
- </tr>
+ <ul class="list-group">
+ @foreach ($pwdTokens as $token => $publicKey)
+ <li class="list-group-item credential-item">
+ <div class="row row_desc">
+ <div class="col-md-12 pwd_description">
+ <p><strong>{{{ $publicKey }}}</strong></p>
+ </div>
+ </div><!-- .row -->
+ <div class="row row_details">
+ <div class="col-md-6">
+ <div class="input-group">
+ <input type="text" class="form-control
public-key" readonly
+
id="credential-publickey-{{$token}}"
+ value="{{ $token }}">
+ <span class="input-group-btn">
+ <button type="button" class="btn
btn-default copy-credential"
+
data-clipboard-target="#credential-publickey-{{$token}}"
+ data-toggle="tooltip"
data-placement="bottom"
+ data-title="Copied!"
data-trigger="manual">
+ Copy
+ </button>
+ </span>
+ </div>
+ </div>
+ <div class="col-md-6">
+ <button data-token="{{$token}}"class="btn
btn-danger remove-pwd-token"
+ @if(!Session::has("admin") ||
$publicKey=="Keycloak admin password for realm default") disabled
@endif>Delete</button>
Review comment:
Let's not do anything special with passwords based on their description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Gateway credential store UI also to have the same format as individual user
> settings
> ------------------------------------------------------------------------------------
>
> Key: AIRAVATA-2279
> URL: https://issues.apache.org/jira/browse/AIRAVATA-2279
> Project: Airavata
> Issue Type: Bug
> Components: PGA PHP Web Gateway
> Environment: dev.seagrid.org
> Reporter: Eroma
> Assignee: Marcus Christie
> Priority: Major
> Fix For: 0.18
>
>
> Currently there are no description ora copy button to copy the public key in
> gateway credential store.
> Unifying the UI with User settings will make it easy for the gateway admins.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
