[
https://issues.apache.org/jira/browse/AIRAVATA-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16411479#comment-16411479
]
ASF GitHub Bot commented on AIRAVATA-2657:
------------------------------------------
DImuthuUpe commented on a change in pull request #167: [AIRAVATA-2657]
Refactoring App Catalog Implementation - ApplicationDeployment and
ApplicationInterface Modules
URL: https://github.com/apache/airavata/pull/167#discussion_r176755093
##########
File path:
modules/registry-refactoring/src/main/java/org/apache/airavata/registry/core/repositories/appcatalog/ApplicationInterfaceRepository.java
##########
@@ -55,6 +56,9 @@ protected ApplicationInterfaceEntity
saveApplicationInterface(
String applicationInterfaceId =
applicationInterfaceDescription.getApplicationInterfaceId();
Mapper mapper = ObjectMapperSingleton.getInstance();
ApplicationInterfaceEntity applicationInterfaceEntity =
mapper.map(applicationInterfaceDescription, ApplicationInterfaceEntity.class);
+ if (!isApplicationInterfaceExists(applicationInterfaceId))
Review comment:
It is good to have curly braces {} even though you have one line if
statement. That improves the readability of the code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Refactoring App Catalog implementation - ApplicationDeployment and
> ApplicationInterface
> ---------------------------------------------------------------------------------------
>
> Key: AIRAVATA-2657
> URL: https://issues.apache.org/jira/browse/AIRAVATA-2657
> Project: Airavata
> Issue Type: Task
> Components: Application Catalog
> Reporter: Sneha Tilak
> Assignee: Sneha Tilak
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
