[
https://issues.apache.org/jira/browse/AIRAVATA-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413920#comment-16413920
]
ASF GitHub Bot commented on AIRAVATA-2619:
------------------------------------------
machristie commented on a change in pull request #182: [AIRAVATA-2619]
Refactoring App Catalog implementation - StorageResource
URL: https://github.com/apache/airavata/pull/182#discussion_r177089054
##########
File path:
modules/registry-refactoring/src/main/java/org/apache/airavata/registry/core/entities/appcatalog/StorageInterfacePK.java
##########
@@ -22,21 +22,23 @@
import javax.persistence.Column;
import javax.persistence.Embeddable;
+import javax.persistence.Id;
import java.io.Serializable;
/**
* The primary key class for the storage_interface database table.
*
*/
-@Embeddable
public class StorageInterfacePK implements Serializable {
//default serial version id, required for serializable classes.
private static final long serialVersionUID = 1L;
@Column(name="STORAGE_RESOURCE_ID", insertable=false, updatable=false)
+ @Id
Review comment:
Don't need `@Column` or `@Id`. Non-embedded composite keys don't need any
JPA annotations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Refactoring App Catalog implementation
> --------------------------------------
>
> Key: AIRAVATA-2619
> URL: https://issues.apache.org/jira/browse/AIRAVATA-2619
> Project: Airavata
> Issue Type: Sub-task
> Reporter: Sachin Kariyattin
> Assignee: Sachin Kariyattin
> Priority: Major
>
> The app catalog module contains the following Impl classes.
> {quote}ApplicationDeploymentImpl
> ApplicationInterfaceImpl
> ComputeResourceImpl
> GwyResourceProfileImpl
> StorageResourceImpl
> UsrResourceProfileImpl
> {quote}
> This task involves creating a repository class for app catalog and include
> all the methods from the Impl classes mentioned above. As a modular approach
> is being followed, to start of, only methods GwyResourceProfileImpl will be
> considered. So the RegistryServiceHandler methods only with respect to
> GwyResourceProfileImpl will be modified. Subsequently all methods related to
> app catalog will be refactored.
> *Progress*:
> * Implemeted GatewayResourceProfileRepository.
> * Implemented ComputeResourceRepository.
> * Implemented StorageResourceRepository.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
