DImuthuUpe commented on a change in pull request #6:
URL: https://github.com/apache/airavata-mft/pull/6#discussion_r413447927
##########
File path:
services/resource-service/server/src/main/java/org/apache/airavata/mft/resource/server/backend/file/FileBasedResourceBackend.java
##########
@@ -90,10 +90,10 @@ public boolean deleteSCPStorage(SCPStorageDeleteRequest
request) {
JSONObject r = (JSONObject) resource;
SCPStorage storage = SCPStorage.newBuilder()
-
.setStorageId(((JSONObject)r.get("scpStorage")).get("storageId").toString())
-
.setHost(((JSONObject)r.get("scpStorage")).get("host").toString())
-
.setUser(((JSONObject)r.get("scpStorage")).get("user").toString())
-
.setPort(Integer.parseInt(((JSONObject)r.get("scpStorage")).get("port").toString())).build();
+ .setStorageId(((JSONObject)
r.get("scpStorage")).get("storageId").toString())
Review comment:
Yes please do. Try to keep the changes as much as relevant to the PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
