aarushiibisht commented on a change in pull request #15:
URL: https://github.com/apache/airavata-mft/pull/15#discussion_r418398914



##########
File path: 
services/resource-service/server/src/main/java/org/apache/airavata/mft/resource/server/backend/file/FileBasedResourceBackend.java
##########
@@ -383,4 +385,75 @@ public boolean 
updateDropboxResource(DropboxResourceUpdateRequest request) throw
     public boolean deleteDropboxResource(DropboxResourceDeleteRequest request) 
throws Exception {
         throw new UnsupportedOperationException("Operation is not supported in 
backend");
     }
+
+    @Override
+    public Optional<FTPResource> getFTPResource(FTPResourceGetRequest request) 
throws Exception {
+        InputStream inputStream = 
FileBasedResourceBackend.class.getClassLoader().getResourceAsStream("resources.json");

Review comment:
       Minor Suggestion: instead of hard coding the name of resource file use 
field resourceFile




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to