DImuthuUpe commented on a change in pull request #13:
URL: https://github.com/apache/airavata-mft/pull/13#discussion_r418654882
##########
File path: services/secret-service/server/src/main/resources/secrets.json
##########
@@ -32,5 +32,11 @@
"type": "DROPBOX",
"secretId": "dropbox-cred",
"accessToken": ""
+ },
+ {
+ "type": "FTP",
Review comment:
Remove passwords and specific user ids. Make them generic as possible
##########
File path:
services/resource-service/server/src/main/java/org/apache/airavata/mft/resource/server/backend/sql/entity/FTPStorageEntity.java
##########
@@ -0,0 +1,48 @@
+package org.apache.airavata.mft.resource.server.backend.sql.entity;
Review comment:
License headers?
##########
File path:
services/resource-service/server/src/main/java/org/apache/airavata/mft/resource/server/backend/sql/entity/FTPResourceEntity.java
##########
@@ -0,0 +1,57 @@
+package org.apache.airavata.mft.resource.server.backend.sql.entity;
Review comment:
License headers?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
