lahirujayathilake commented on code in PR #524:
URL: https://github.com/apache/airavata-custos/pull/524#discussion_r3591910320
##########
web/src/app/(portal)/admin/users/roles/RoleFormDialog.tsx:
##########
@@ -140,57 +125,17 @@ export function RoleFormDialog({
<PermissionMatrixEditor
permissions={permissions}
+ catalog={catalog}
onTogglePermission={(key) => setPermissions((prev) =>
togglePermission(prev, key))}
/>
-
- <div className="border-t border-border" />
-
- <div className="space-y-2">
- <Label htmlFor="role-user-search">Assign to users
(optional)</Label>
- <Input
- id="role-user-search"
- type="search"
- value={userSearch}
- onChange={(e) => setUserSearch(e.target.value)}
- placeholder="Search by username or email"
- />
- <ul className="max-h-40 space-y-1 overflow-y-auto rounded-md
border p-2">
- {matchingUsers.length === 0 ? (
- <li className="px-1 py-1 text-sm text-muted-foreground">No
users match.</li>
- ) : (
- matchingUsers.map((u) => {
- const id = u.id ?? u.email ?? "";
- return (
- <li key={id}>
- <label className="flex cursor-pointer items-center gap-2
rounded-sm px-1 py-1 text-sm hover:bg-muted">
- <input
- type="checkbox"
- checked={selectedUserIds.has(id)}
- onChange={() => toggleUserSelected(id)}
- className="size-4 rounded border-input"
- />
- <span className="font-medium
text-foreground">{fullNameFor(u)}</span>
- <span className="text-xs
text-muted-foreground">{u.email}</span>
- </label>
- </li>
- );
- })
- )}
- </ul>
Review Comment:
This is to assign a role to many users at once. If user management has that,
dropping it here is the right call. Today it only does the reverse (one user,
many roles), so that feature is still needed, either back here or in user
management.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
