Copilot commented on code in PR #784:
URL: https://github.com/apache/airavata/pull/784#discussion_r4618481233


##########
docs/api.md:
##########
@@ -4,7 +4,7 @@ Base URL: `http://localhost:9095` (default `SERVER_PORT` is 
`9095`; override via
 
 This page is the narrative reference, with a worked `curl` example per 
endpoint. [`openapi.yaml`](openapi.yaml) beside it is the same API as a 
machine-readable OpenAPI 3.1 description, for client generation and for loading 
into Swagger UI or Redoc.\n\nSharing works the same way for every record that 
supports it, so it is documented once in **[sharing.md](sharing.md)** — the 
access model, who may grant what, and worked examples — rather than repeated 
under each resource below.
 
-All request/response bodies are JSON (`Content-Type: application/json`). 
Writes require an `Authorization: Bearer <token>` header for a principal with 
`ADMIN` or `SUPER_ADMIN` authority; catalog reads (`GET`) are open without a 
token. [SSH credentials](#ssh-credentials), [groups](#groups), [cluster 
configs](#slurm-cluster-configs), [data products](#data-products) and [SCP data 
storages](#scp-data-storages) are the exception on both counts — they are 
reached through ownership (and, for all but a credential, sharing rules) rather 
than platform roles, so any authenticated caller may create them, and none are 
readable anonymously. See INSTALL.md for how to obtain the root token.
+All request/response bodies are JSON (`Content-Type: application/json`). 
Writes require an `Authorization: Bearer <token>` header for a principal with 
`ADMIN` or `SUPER_ADMIN` authority; catalog reads (`GET` on clusters, 
partitions, application templates and batch deployments) need a token but no 
particular role — any authenticated caller may read them; anonymous callers get 
`401`. [SSH credentials](#ssh-credentials), [groups](#groups), [cluster 
configs](#slurm-cluster-configs), [data products](#data-products) and [SCP data 
storages](#scp-data-storages) are the exception on writes — they are reached 
through ownership (and, for all but a credential, sharing rules) rather than 
platform roles, so any authenticated caller may create them, and reads are 
limited to their owner and whoever they are shared with. See INSTALL.md for how 
to obtain the root token.

Review Comment:
   The worked Create Process example at docs/api.md:1840 still fetches 
`/api/v1/application-templates/"$TEMPLATE_ID"` without an Authorization header. 
With the new authentication requirement, that command receives a 401 error 
body, and the following jq expressions cannot extract the input/output IDs 
needed for submission. Please add the `Authorization: Bearer $TOKEN` header to 
that GET as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to