[ https://issues.apache.org/jira/browse/AMBARI-15979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15250990#comment-15250990 ]
Hadoop QA commented on AMBARI-15979: ------------------------------------ {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12799786/AMBARI-15979-April-20.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in ambari-web. Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/6568//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/6568//console This message is automatically generated. > Provide UI validation for widget_name and description fields in Create/Edit > Widget pop-up. > ------------------------------------------------------------------------------------------ > > Key: AMBARI-15979 > URL: https://issues.apache.org/jira/browse/AMBARI-15979 > Project: Ambari > Issue Type: Improvement > Components: ambari-web > Affects Versions: trunk > Reporter: Keta Patel > Assignee: Keta Patel > Attachments: AMBARI-15979-April-20.patch, AMBARI-15979.patch, > create_widget_button_location.tiff, create_widget_step1.tiff, > create_widget_step2.tiff, create_widget_step3.tiff, > fixed_character_validation_for_description.tiff, > fixed_character_validation_for_name.tiff, > fixed_characters_allowed_for_description.tiff, > fixed_characters_allowed_for_name.tiff, > fixed_length_validation_for_description.tiff, > fixed_length_validation_for_name.tiff, > original_characters_allowed_for_name_and_description.tiff, > original_length_validation_for_description.tiff, > original_length_validation_for_name.tiff > > > The UI validation at present checks only the length of the user input for > widget_name and description fields. All characters are allowed to be stored > in the database through them. A more strict UI validation that limits the > type of characters entered for these fields will provide a good first line of > defense. > Steps to reproduce: > 1. Make sure you have Ambari Metrics service installed on your cluster. > 2. On the Dashboard, select any service that makes use of Ambari Metrics, say > HDFS. > 3. In the "Metrics" section, click the "Actions" button in the top-right > corner, and select "Create a new widget" option from the drop-down. > (attachment: create_widget_button_location.tiff) > 4. Create widget pop-up is displayed. > 5. On Step-1, select any type for the widget and click "Next". (attachment: > create_widget_step1.tiff) > 6. On Step-2, select any valid metrics parameter and click "Next". > (attachment: create_widget_step2.tiff) > 7. On Step-3, for widget_name and description fields, you can enter any > character. No validation is present to check the contents. The only > validation present checks the length of the input text. > (attachments: > create_widget_step3.tiff, > original_characters_allowed_for_name_and_description.tiff, > original_length_validation_for_name.tiff, > original_length_validation_for_description.tiff ) -- This message was sent by Atlassian JIRA (v6.3.4#6332)