[ 
https://issues.apache.org/jira/browse/AMBARI-18126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15422077#comment-15422077
 ] 

Masahiro Tanaka commented on AMBARI-18126:
------------------------------------------

Hi [~jonathan.hurley], I think this patch may break the UT.
After the commit {{b1a6340}}, I got a compilation error

{code}
[INFO] ------------------------------------------------------------------------
[INFO] Building Ambari Functional Tests 2.0.0.0-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO][info] --- maven-clean-plugin:2.5:clean (default-clean) @ ambari-funtest 
---
[INFO] Deleting /tmp/ambari/ambari-funtest/target
[INFO] Deleting /tmp/ambari/ambari-funtest (includes = [*/.pyc], excludes = [])
[INFO][info] --- build-helper-maven-plugin:1.8:regex-property 
(parse-package-version) @ ambari-funtest --
-
[INFO][info] --- build-helper-maven-plugin:1.8:regex-property 
(parse-package-release) @ ambari-funtest --
-
[INFO][info] --- maven-resources-plugin:2.5:resources (default-resources) @ 
ambari-funtest ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 
/tmp/ambari/ambari-funtest/src/main/resources
[INFO] skip non existing resourceDirectory 
/tmp/ambari/ambari-funtest/src/main/resources
[INFO][info] --- maven-compiler-plugin:3.0:compile (default-compile) @ 
ambari-funtest ---
[INFO] No sources to compile
[INFO][info] --- maven-resources-plugin:2.5:testResources 
(default-testResources) @ ambari-funtest ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 353 resources
[INFO][info] --- maven-compiler-plugin:3.0:testCompile (default-testCompile) @ 
ambari-funtest ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 44 source files to 
/tmp/ambari/ambari-funtest/target/test-classes
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] 
/tmp/ambari/ambari-funtest/src/test/java/org/apache/ambari/funtest/server/tests/ServerTestB
ase.java:[102,49] cannot find symbol
symbol: variable SERVER_PERSISTENCE_TYPE_KEY
location: class org.apache.ambari.server.configuration.Configuration
[ERROR] 
/tmp/ambari/ambari-funtest/src/test/java/org/apache/ambari/funtest/server/tests/ServerTestB
ase.java:[103,49] cannot find symbol
symbol: variable SERVER_JDBC_URL_KEY
location: class org.apache.ambari.server.configuration.Configuration
{code}

Could you update the patch? Thank you.

> Refactor Configuration To Allow For Generation Of Documentation
> ---------------------------------------------------------------
>
>                 Key: AMBARI-18126
>                 URL: https://issues.apache.org/jira/browse/AMBARI-18126
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-server
>    Affects Versions: trunk
>            Reporter: Jonathan Hurley
>            Assignee: Jonathan Hurley
>            Priority: Critical
>             Fix For: trunk
>
>         Attachments: AMBARI-18126.patch
>
>
> As part of the work for AMBARI-18089, all of the potential properties from 
> {{ambari.properties}} need a way to be organized and queried in order to 
> generate documentation. 
> This Jira proposes to change our disorganized String/String (key/default) 
> structure found in {{Configuration}}, and instead, have a strongly-coupled 
> relationship between key/default/type. 
> Additionally, expose a way to provide extra information in the markdown 
> (similar to JavaDoc, but geared more for users and not developers).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to