[ https://issues.apache.org/jira/browse/AMBARI-19138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15732775#comment-15732775 ]
Hadoop QA commented on AMBARI-19138: ------------------------------------ {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12842339/AMBARI-19138.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The test build failed in ambari-server Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/9592//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/9592//console This message is automatically generated. > Option for getting heap dump for Hive and Tez services. > ------------------------------------------------------- > > Key: AMBARI-19138 > URL: https://issues.apache.org/jira/browse/AMBARI-19138 > Project: Ambari > Issue Type: Bug > Components: ambari-server > Affects Versions: 2.4.1 > Reporter: Swapan Shridhar > Assignee: Swapan Shridhar > Fix For: 2.5.0 > > Attachments: AMBARI-19138.patch > > > We need to add the heap dump option for: > - All Hive services (Hive1/HiveServer2, Hive2/HiveServer2 and Metastore): > {code} > -XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=<'/tmp/' by default or > 'Configurable location provided'> > {code} > option appended to "Advance hive-env" -> hive-env-template -> > HADOOP_CLIENT_OPTS environment variable > - HSI YARN jobs: > {code} > -XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=<'/tmp/' by default or > 'Configurable location provided'> > {code} > option added to "Advanced hive-interactive-env" -> Llap app java opts. Logs > will be generated at: /<'Configurable location > provided'>/java_<pid-of-llap-daemon>.hprof on the nodes that failed with OOM. > - Tez component: > {code} > -XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=<'/tmp/' by default or > 'Configurable location provided'> > {code} > option added to tez.am.launch.cmd-opts for AM OOM and > tez.task.launch.cmd-opts for task OOM. > *>>>>* 'Configurable location provided' should be one config where user can > change the location and consumable by all others. > Further, whether to keep the heap dump option ENABLED or DISABLED should be > configurable via Ambari. [~carter] to confirm for this. By default, option > should be DISABLED. > *>>>>* ENABLING/DISABLING of option will require the above components > RESATARt for change to take effect. > *>>>>* permissions for dump file can be 600 for <hive user>:<hive group>. -- This message was sent by Atlassian JIRA (v6.3.4#6332)