[ https://issues.apache.org/jira/browse/AMBARI-19618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15831353#comment-15831353 ]
Hadoop QA commented on AMBARI-19618: ------------------------------------ {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12848466/AMBARI-19618.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 8 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in ambari-server ambari-web: org.apache.ambari.server.stack.StackManagerTest org.apache.ambari.server.state.ConfigHelperTest Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/10164//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/10164//console This message is automatically generated. > Make cohosted components configurable in metainfo.xml instead of hardcoding > in UI > --------------------------------------------------------------------------------- > > Key: AMBARI-19618 > URL: https://issues.apache.org/jira/browse/AMBARI-19618 > Project: Ambari > Issue Type: Improvement > Affects Versions: trunk > Reporter: Yao Lei > Fix For: trunk, 3.0.0 > > Attachments: after_patched_hive1.png, after_patched_hive2.png, > after_patched_ranger1.png, after_patched_ranger2.png, > after_patched_ranger3.png, AMBARI-19618.patch > > > Cohosted components information now is hardcoded in > stack_service_component.js as following: > App.StackServiceComponent.coHost = { > 'WEBHCAT_SERVER': 'HIVE_SERVER' > }; > It's better to move them from javascript to metainfom.xml by adding tag > <coHost></coHost>in stack like following: > <component> > <name>WEBHCAT_SERVER</name> > <displayName>WebHCat Server</displayName> > <category>MASTER</category> > <cardinality>1</cardinality> > <versionAdvertised>true</versionAdvertised> > <reassignAllowed>true</reassignAllowed> > <coHost>HIVE_SERVER</coHost> > </component> > <component> > <name>RANGER_USERSYNC</name> > <displayName>Ranger Usersync</displayName> > <category>MASTER</category> > <cardinality>1</cardinality> > <versionAdvertised>true</versionAdvertised> > <coHost>RANGER_ADMIN</coHost> > </component> -- This message was sent by Atlassian JIRA (v6.3.4#6332)