[
https://issues.apache.org/jira/browse/AMBARI-15024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15851974#comment-15851974
]
Robert Nettleton commented on AMBARI-15024:
-------------------------------------------
Hi [~gss2002], As [~avijayan] mentioned it would probably be best to post this
to the Apache ReviewBoard, and have this patch reviewed there.
In general, the idea of the patch is fine with me, but I would recommend
changing the following:
In AmbariManagementControllerImplTest, the following assertion was introduced
by this patch:
{code}assertTrue(defaultHostParams.get(JAVA_VENDOR).equals("ibm") ||
defaultHostParams.get(JAVA_VENDOR).equals("oracle"));{code}
I would recommend either removing this assertion, or making it more flexible.
My concern here would be if a developer attempts to run the ambari-server unit
tests on a JDK install that is provided by a different vendor, which would case
the test to fail.
Thanks.
CC [~u39kun], [~swagle]
> Ability for Ambari to determine java_vendor and pass it as hostLevelParam
> -------------------------------------------------------------------------
>
> Key: AMBARI-15024
> URL: https://issues.apache.org/jira/browse/AMBARI-15024
> Project: Ambari
> Issue Type: Improvement
> Components: ambari-server
> Reporter: Greg Senia
> Labels: ibm-jdk
> Fix For: 2.5.0
>
> Attachments: AMBARI-15024.patch
>
>
> Adding the ability to pass java_vendor down to ambari-agent as a
> hostLevelParam will allow other JDKs to be put into place such as the IBM JDK
> which has different tuning params when it comes to hadoop-env.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
