[ 
https://issues.apache.org/jira/browse/AMBARI-20122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jaimin Jetly reopened AMBARI-20122:
-----------------------------------

The commit has been reverted because it was blocking from deploying clusters 
via ambari-web:

Selecting any partial set of service on "Select Services" page was causing 
stack advisor recommendation call to fail with following error:

{code}
Traceback (most recent call last):
  File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 167, 
in <module>
    main(sys.argv)
  File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 108, 
in main
    result = stackAdvisor.recommendComponentLayout(services, hosts)
  File "/var/lib/ambari-server/resources/scripts/../stacks/stack_advisor.py", 
line 608, in recommendComponentLayout
    layoutRecommendations = self.createComponentLayoutRecommendations(services, 
hosts)
  File 
"/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.5/services/stack_advisor.py",
 line 91, in createComponentLayoutRecommendations
    services, hosts)
  File "/var/lib/ambari-server/resources/scripts/../stacks/stack_advisor.py", 
line 760, in createComponentLayoutRecommendations
    sortedServices = self.getServicesSortedByDependencies(services)
  File "/var/lib/ambari-server/resources/scripts/../stacks/stack_advisor.py", 
line 886, in getServicesSortedByDependencies
    self.sortServicesByDependencies(services, service, processedServices, 
sortedServices)
  File "/var/lib/ambari-server/resources/scripts/../stacks/stack_advisor.py", 
line 911, in sortServicesByDependencies
    self.sortServicesByDependencies(services, requiredService, 
processedServices, sortedServices)
  File "/var/lib/ambari-server/resources/scripts/../stacks/stack_advisor.py", 
line 901, in sortServicesByDependencies
    for component in service["components"]:
TypeError: 'NoneType' object is unsubscriptable
{code}



> Stack advisor needs to recommend dependency for slaves and masters
> ------------------------------------------------------------------
>
>                 Key: AMBARI-20122
>                 URL: https://issues.apache.org/jira/browse/AMBARI-20122
>             Project: Ambari
>          Issue Type: Task
>          Components: ambari-server
>    Affects Versions: 3.0.0
>            Reporter: Jaimin Jetly
>            Assignee: Tim Thorpe
>             Fix For: 3.0.0
>
>         Attachments: AMBARI-20122.patch
>
>
> After resolution of AMBARI-19685, stack advisor validates if stack defined 
> dependency is not satisfied but recommendation API does not account for this.
> Stack defined dependencies are service/component based and has a scope 
> CLUSTER|HOST.  
> During recommendation the services to install have already been selected.  We 
> can't really utilize the cluster scope because either the dependent service 
> was selected or it was not.  If it was not selected it will be caught during 
> validation.  We can only recommend based on HOST scope.
> This JIRA is also limited to only handling those which don't have conditional 
> dependencies.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to