[
https://issues.apache.org/jira/browse/AMBARI-21592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16104112#comment-16104112
]
Hadoop QA commented on AMBARI-21592:
------------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12879258/AMBARI-21592.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
ambari-logsearch/ambari-logsearch-logfeeder.
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/11881//console
This message is automatically generated.
> Log Feeder properties should be handled by one class
> ----------------------------------------------------
>
> Key: AMBARI-21592
> URL: https://issues.apache.org/jira/browse/AMBARI-21592
> Project: Ambari
> Issue Type: Improvement
> Components: ambari-logsearch
> Affects Versions: 3.0.0
> Reporter: Miklos Gergely
> Assignee: Miklos Gergely
> Fix For: 3.0.0
>
> Attachments: AMBARI-21592.patch
>
>
> Log Feeder properties are scattered all over the code, with their
> documentation, putting large blocks of codes into several classes. Instead of
> it they should be handled by one class together with their documentation and
> default values, having all the rest of the classes asking that one for their
> value.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
