[
https://issues.apache.org/jira/browse/AMBARI-22764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322159#comment-16322159
]
ASF GitHub Bot commented on AMBARI-22764:
-----------------------------------------
atkach closed pull request #87: [AMBARI-22764] NN HA wizard is broken due to
recent commit for config…
URL: https://github.com/apache/ambari/pull/87
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ambari-web/app/templates/common/configs/service_config.hbs
b/ambari-web/app/templates/common/configs/service_config.hbs
index 34ac6029576..fe9706279ae 100644
--- a/ambari-web/app/templates/common/configs/service_config.hbs
+++ b/ambari-web/app/templates/common/configs/service_config.hbs
@@ -188,7 +188,7 @@
{{view App.SpinnerView}}
{{/if}}
-<div class="configs-save-panel" {{bindAttr
class="view.showSavePanel::hidden"}}>
+<div {{bindAttr class="view.showSavePanel::hidden :configs-save-panel"}}>
<div class="pull-right">
<button class="btn btn-default" {{action doCancel target="controller"}}
{{bindAttr disabled="view.isDiscardDisabled"}}>
diff --git
a/ambari-web/app/views/common/configs/service_configs_by_category_view.js
b/ambari-web/app/views/common/configs/service_configs_by_category_view.js
index 4726c612e1b..ffa4bfea738 100644
--- a/ambari-web/app/views/common/configs/service_configs_by_category_view.js
+++ b/ambari-web/app/views/common/configs/service_configs_by_category_view.js
@@ -189,7 +189,7 @@ App.ServiceConfigsByCategoryView =
Em.View.extend(App.Persist, App.ConfigOverrid
*/
isShowBlock: function () {
const isFilterEmpty = this.get('controller.filter') === '';
- const isFilterActive =
this.get('mainView.columns').someProperty('selected');
+ const isFilterActive = this.get('mainView.columns') &&
this.get('mainView.columns').someProperty('selected');
const isCustomPropertiesCategory =
this.get('category.customCanAddProperty');
const isCompareMode = this.get('controller.isCompareMode');
const hasFilteredAdvancedConfigs =
this.get('categoryConfigs').filter(function (config) {
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> NN HA wizard is broken due to recent commit for config compare
> --------------------------------------------------------------
>
> Key: AMBARI-22764
> URL: https://issues.apache.org/jira/browse/AMBARI-22764
> Project: Ambari
> Issue Type: Bug
> Components: ambari-web
> Affects Versions: 3.0.0
> Reporter: Andrii Tkach
> Assignee: Andrii Tkach
> Fix For: 3.0.0
>
> Attachments: AMBARI-22764.patch, log1.png, log2.png
>
>
> Save button on NN HA wizard step3 is disabled.
> Screenshots attached.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
