[ https://issues.apache.org/jira/browse/AMBARI-24296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661013#comment-16661013 ]
Hudson commented on AMBARI-24296: --------------------------------- SUCCESS: Integrated in Jenkins build Ambari-branch-2.7 #378 (See [https://builds.apache.org/job/Ambari-branch-2.7/378/]) [AMBARI-24296] Yarn Queue manager is allowing to Create a Child Queue (jonathanhurley: [https://gitbox.apache.org/repos/asf?p=ambari.git&a=commit&h=56c8ccf77506ddc1268ee1925f3ca0f73bdfb9da]) * (edit) contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queues.js > [Yarn Queue Manager] Yarn Queue manager is allowing to Create a Child Queue > for queue-mappings enabled Queue and Save it > ------------------------------------------------------------------------------------------------------------------------ > > Key: AMBARI-24296 > URL: https://issues.apache.org/jira/browse/AMBARI-24296 > Project: Ambari > Issue Type: Bug > Components: ambari-views > Affects Versions: 2.7.0 > Reporter: Akhil S Naik > Assignee: Akhil S Naik > Priority: Major > Labels: pull-request-available > Time Spent: 1h 20m > Remaining Estimate: 0h > > Yarn Queue manager is allowing to Create a Child Queue for queue-mappings > enabled Queue and Save the changes > But the Operating is Failing as Yarn is having a check that Queue-mappings > should only be allowed for Leaf queue > Code which validates whether queue-mappings are enabled only for leaf-queue ( > YARN CODE) > {code:java} > private static QueueMapping validateAndGetQueueMapping( > CapacitySchedulerQueueManager queueManager, CSQueue queue, > QueueMapping mapping, QueuePath queuePath) throws IOException { > if (!(queue instanceof LeafQueue)) { > throw new IOException( > "mapping contains invalid or non-leaf queue : " + > mapping.getQueue()); > } > {code} > The buggy code in [Ambari Yarn Queue Manager which needs rework]: > https://github.com/apache/ambari/blob/79cca1c7184f1661236971dac70d85a83fab6c11/contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queues.js#L410 > {code:java} > hasInvalidMapping = queues.filter(function(queue){ > return !queue.get("queues"); //get all leaf queues > }).map(function(queue){ > return queue.get("name"); > }).indexOf(mapping[2]) == -1; > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)