[
https://issues.apache.org/jira/browse/AMBARI-24895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688589#comment-16688589
]
ASF GitHub Bot commented on AMBARI-24895:
-----------------------------------------
oleewere commented on a change in pull request #15: AMBARI-24895 - Infra
Manager: code clean up
URL: https://github.com/apache/ambari-infra/pull/15#discussion_r233993364
##########
File path:
ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/InfraClient.java
##########
@@ -49,7 +49,7 @@
// TODO: use swagger
public class InfraClient implements AutoCloseable {
- private static final Logger LOG = LoggerFactory.getLogger(InfraClient.class);
+ private static final Logger logger =
LoggerFactory.getLogger(InfraClient.class);
Review comment:
@adoroszlai what the compiler thinks it is
(https://docs.oracle.com/javase/specs/jls/se7/html/jls-15.html#jls-15.28),
primitives/arrays or classes/objects where the state cannot change anyhow.
object immutability is not enough here, like Logger is an interface. but
another opposite example that can be constant is a list (created from a static
method), which has final add/remove methods. also worth to check what you can
use in annotations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Infra Manager: code clean up
> ----------------------------
>
> Key: AMBARI-24895
> URL: https://issues.apache.org/jira/browse/AMBARI-24895
> Project: Ambari
> Issue Type: Task
> Components: ambari-infra
> Affects Versions: 2.8.0
> Reporter: Krisztian Kasa
> Assignee: Krisztian Kasa
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.8.0
>
>
> * rename LOG -> logger
> * remove slf4j use log4j2
> * merge Job Properties and Job Parameter classes
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
