[
https://issues.apache.org/jira/browse/AMBARI-26525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18003518#comment-18003518
]
Gandhe harshith commented on AMBARI-26525:
------------------------------------------
[~jialiang] , digging more, its little funny. if you search
db_connection_check_command in that code, i cannot see how it cannot be a
string, like it wouldn't go into else. I think the else condition is a dead
code. thoughts ?
> Additional change required for AMBARI-26517
> -------------------------------------------
>
> Key: AMBARI-26525
> URL: https://issues.apache.org/jira/browse/AMBARI-26525
> Project: Ambari
> Issue Type: Bug
> Components: ambari-server
> Affects Versions: 3.0.0
> Reporter: Gandhe harshith
> Assignee: Gandhe harshith
> Priority: Major
> Fix For: 3.1.0
>
>
> I think an additonal change / fix was missing at
> [https://github.com/develop-vijay/ambari/commit/f4943eab683e2d22f486543c976088b4c6a18ef8]
>
>
> {code:java}
> if isinstance(db_connection_check_command, str):
> code, out = shell.call(
> split(db_connection_check_command, comments=True), shell=False,
> quiet=True
> )
> else:
> code, out = shell.call(db_connection_check_command, shell=False) {code}
> quiet=True , when db_connection_check_command is str, but when its tuple or
> something else, it will get printed right ? doesnt it defeat the purpose of
> that ticket in this case ?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
